Skip to content
This repository has been archived by the owner on May 26, 2024. It is now read-only.

Add support for BDS NMEA messages #58

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Add support for BDS NMEA messages #58

merged 4 commits into from
Nov 21, 2022

Conversation

aentinger
Copy link
Member

Sorry @klren0312, I accidentally messed up your PR #57.

However, this PR contains your commits so you can credit this contribution to your github account =)

Btw. it's always better to send a PR from a separate branch within your forked repository, sending a PR from master is difficult at best and I mangle it nearly every time.

@aentinger aentinger added type: enhancement PR to improve the project. topic: firmware Code that runs on an embedded system. labels Nov 21, 2022
@aentinger aentinger self-assigned this Nov 21, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 91.57% // Head: 91.23% // Decreases project coverage by -0.34% ⚠️

Coverage data is based on head (44f0481) compared to base (aa074c6).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   91.57%   91.23%   -0.35%     
==========================================
  Files          10       10              
  Lines         380      388       +8     
==========================================
+ Hits          348      354       +6     
- Misses         32       34       +2     
Impacted Files Coverage Δ
src/nmea/GxGGA.cpp 77.06% <0.00%> (-1.45%) ⬇️
src/nmea/GxRMC.cpp 97.80% <100.00%> (+0.04%) ⬆️
src/nmea/util/gga.cpp 100.00% <100.00%> (ø)
src/nmea/util/rmc.cpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aentinger aentinger merged commit a9a9676 into master Nov 21, 2022
@aentinger aentinger deleted the bds branch November 21, 2022 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: firmware Code that runs on an embedded system. type: enhancement PR to improve the project.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants